From danger@tomas.elvandar.org Sat Jan 28 22:09:32 2006 Return-Path: Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E50516A420 for ; Sat, 28 Jan 2006 22:09:32 +0000 (GMT) (envelope-from danger@tomas.elvandar.org) Received: from tomas.elvandar.org (tomas.elvandar.org [217.148.169.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 508B243D48 for ; Sat, 28 Jan 2006 22:09:32 +0000 (GMT) (envelope-from danger@tomas.elvandar.org) Received: by tomas.elvandar.org (Postfix, from userid 1002) id AB8FF4845E4; Sat, 28 Jan 2006 22:09:30 +0000 (UTC) Message-Id: <20060128220930.AB8FF4845E4@tomas.elvandar.org> Date: Sat, 28 Jan 2006 22:09:30 +0000 (UTC) From: Daniel Gerzo Reply-To: Daniel Gerzo To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: [patch] fix for the xsl template X-Send-Pr-Version: 3.113 X-GNATS-Notify: >Number: 92474 >Category: www >Synopsis: [patch] fix for the xsl template >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-www >State: closed >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Sat Jan 28 22:10:02 GMT 2006 >Closed-Date: Sun Feb 05 12:14:27 GMT 2006 >Last-Modified: Sun Feb 05 12:14:27 GMT 2006 >Originator: Daniel Gerzo >Release: FreeBSD 6.0 i386 >Organization: rulez.sk >Environment: System: FreeBSD 6.0-RELEASE #3: Fri Nov 4 21:58:23 CET 2005 >Description: the current www/share/sgml/includes.header.xsl is buggy, since the "if" statement is wrong there according to the comment in the www/share/sgml/includes.release.xsl file which says: "An upcoming release that we want tested. Set $beta.testing to 0 if we're not in the middle of a release cycle. Ha ha." As we are not in the middle of RC (and the $beta.testing is set to '0'), the web pages generated from xsl are still containing URLs for 6.0-RC1 because of this wrong "if". >How-To-Repeat: check some web page generated from xsl template including links to the release/download menu >Fix: Use this patch: --- includes.header.xsl.diff begins here --- --- /usr/home/danger/www/share/sgml/includes.header.xsl~ Sun Jan 1 23:28:12 2006 +++ /usr/home/danger/www/share/sgml/includes.header.xsl Sat Jan 28 21:58:20 2006 @@ -197,7 +197,7 @@
  • Production Release:
  • Production (Legacy) Release:
  • Snapshot Releases
    • - +
  • Upcoming Release
    • --- includes.header.xsl.diff ends here --- >Release-Note: >Audit-Trail: From: Ceri Davies To: Daniel Gerzo Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: www/92474: [patch] fix for the xsl template Date: Sun, 5 Feb 2006 00:20:35 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-2--269637957 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed On 28 Jan 2006, at 22:09, Daniel Gerzo wrote: > As we are not in the middle of RC (and the $beta.testing is set to > '0'), > the web pages generated from xsl are still containing URLs for 6.0-RC1 > because of this wrong "if". Can you give an example? I've just checked the two pages that use this code and they look fine. Ceri --Apple-Mail-2--269637957 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (Darwin) iD8DBQFD5UTTme8yCsQvJJ0RArO0AJ9NsVGE/8ehp92rQTz6MaRepIP7KgCdGPLj 2TFrcOjA1xpYa4JOwgcnE7M= =9Tjh -----END PGP SIGNATURE----- --Apple-Mail-2--269637957-- From: Daniel Gerzo To: Ceri Davies Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re[2]: www/92474: [patch] fix for the xsl template Date: Sun, 5 Feb 2006 11:38:33 +0100 Hello Ceri, Sunday, February 5, 2006, 1:20:35 AM, you wrote: > On 28 Jan 2006, at 22:09, Daniel Gerzo wrote: >> As we are not in the middle of RC (and the $beta.testing is set to >> '0'), >> the web pages generated from xsl are still containing URLs for 6.0-RC1 >> because of this wrong "if". > Can you give an example? I've just checked the two pages that use > this code and they look fine. if the xsl template uses this: then you can see the bug, but actually I wasn't able to find any page which uses this currently. I found this bug when I was XML'ifying the release todo list. > Ceri -- Sincerely, Daniel Gerzo State-Changed-From-To: open->closed State-Changed-By: ceri State-Changed-When: Sun Feb 5 12:14:14 UTC 2006 State-Changed-Why: Good catch. Cheers. http://www.freebsd.org/cgi/query-pr.cgi?pr=92474 >Unformatted: